OSGeo.org › OSGeo Software Projects › GeoNetwork opensource › GeoNetwork developer

sprint results: java 11 compatibility

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

jody.garnett

sprint results: java 11 compatibility

GeoNetwork PSC:

I also rounded up some details from java 11 compatibility testing last week (thanks to David for the initial research).

Java 11 Compatibility

I understand there was work on Spring upgrade and JPA upgrade, how did that go?

Jody Garnett

_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Jose Garcia

Re: sprint results: java 11 compatibility

Hi Jody

The work for Spring upgrade and JPA upgrade is already merged in the 4.0.x branch.

Regards,

Jose García

On Tue, Jul 14, 2020 at 5:29 PM Jody Garnett <[hidden email]> wrote:

GeoNetwork PSC:

I also rounded up some details from java 11 compatibility testing last week (thanks to David for the initial research).
Java 11 Compatibility
I understand there was work on Spring upgrade and JPA upgrade, how did that go?
--
Jody Garnett
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664

Please consider the environment before printing this email.

jody.garnett

Re: sprint results: java 11 compatibility

That is good news, updating the page to check that as done.

I believe that a good percentage of the split-package issues identified are a result of our war not being strictly defined.

As an example both jrt:/java.xml.ws, javaee-api-7.0.jar both define javax.jws package, I expect it is a mistake that this is included. Marking items like this that we expect to be provided by jetty or tomcat as scope "provided" will ensure they are available when compiling, but not bundled in our war lib folder to cause split-package problems.

Reference: https://stackoverflow.com/questions/48204141/replacements-for-deprecated-jpms-modules-with-java-ee-apis

On Tue, Jul 14, 2020 at 11:23 PM Jose Garcia <[hidden email]> wrote:

Hi Jody

The work for Spring upgrade and JPA upgrade is already merged in the 4.0.x branch.

Regards,
Jose García

On Tue, Jul 14, 2020 at 5:29 PM Jody Garnett <[hidden email]> wrote:
GeoNetwork PSC:

I also rounded up some details from java 11 compatibility testing last week (thanks to David for the initial research).
Java 11 Compatibility
I understand there was work on Spring upgrade and JPA upgrade, how did that go?
--
Jody Garnett
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664

Please consider the environment before printing this email.

jody.garnett

Re: sprint results: java 11 compatibility

I had a first pass at reviewing the dependencies with an evaluation of update, replace, ignore judgement call.

As an example many of the jai-core warnings do not prevent startup and can be ignored.

I have some questions on that page:

ant-1.6.5.jar

- why do we have a build tool included in the war?

hadoop-core-1.0.0.jar

- what is hadoop used for? this is a distributed computing library right ...

scala-library-2.9.1.jar

- what do we use scala for? scala does not show up as any of the languages used in the repository analytics ....

I do not believe we can make substantial progress on this activity until war is fixed (currently contains multiple competing xml apis):

> split package: javax.xml.parsers [jrt:/java.xml, xml-apis-1.4.01.jar, xmlParserAPIs-2.6.2.jar

> ...

> split package: javax.xml.transform.dom [jrt:/java.xml, xml-apis-1.4.01.jar, xmlParserAPIs-2.6.2.jar]

Jody Garnett

On Wed, 15 Jul 2020 at 09:05, Jody Garnett <[hidden email]> wrote:

That is good news, updating the page to check that as done.

I believe that a good percentage of the split-package issues identified are a result of our war not being strictly defined.

As an example both jrt:/java.xml.ws, javaee-api-7.0.jar both define javax.jws package, I expect it is a mistake that this is included. Marking items like this that we expect to be provided by jetty or tomcat as scope "provided" will ensure they are available when compiling, but not bundled in our war lib folder to cause split-package problems.

Reference: https://stackoverflow.com/questions/48204141/replacements-for-deprecated-jpms-modules-with-java-ee-apis

On Tue, Jul 14, 2020 at 11:23 PM Jose Garcia <[hidden email]> wrote:
Hi Jody

The work for Spring upgrade and JPA upgrade is already merged in the 4.0.x branch.

Regards,
Jose García

On Tue, Jul 14, 2020 at 5:29 PM Jody Garnett <[hidden email]> wrote:
GeoNetwork PSC:

I also rounded up some details from java 11 compatibility testing last week (thanks to David for the initial research).
Java 11 Compatibility
I understand there was work on Spring upgrade and JPA upgrade, how did that go?
--
Jody Garnett
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664

Please consider the environment before printing this email.

Jose Garcia

Re: sprint results: java 11 compatibility

Hi Jody

See inline.

Regards,

Jose García

On Sat, Jul 18, 2020 at 2:17 AM Jody Garnett <[hidden email]> wrote:

I had a first pass at reviewing the dependencies with an evaluation of update, replace, ignore judgement call.

As an example many of the jai-core warnings do not prevent startup and can be ignored.

I have some questions on that page:

ant-1.6.5.jar
- why do we have a build tool included in the war?

hadoop-core-1.0.0.jar
- what is hadoop used for? this is a distributed computing library right ...

This is used in activemq-core 5.6.0 dependency in the messaging module, that is used to index WFS features in ElasticSearch, but not very clear for what is used the JMS messaging. Florent or Francois can provide more details.

scala-library-2.9.1.jar
- what do we use scala for? scala does not show up as any of the languages used in the repository analytics ....

This is used by the activemq-core 5.6.0 dependency also.

I do not believe we can make substantial progress on this activity until war is fixed (currently contains multiple competing xml apis):

> split package: javax.xml.parsers [jrt:/java.xml, xml-apis-1.4.01.jar, xmlParserAPIs-2.6.2.jar
> ...
> split package: javax.xml.transform.dom [jrt:/java.xml, xml-apis-1.4.01.jar, xmlParserAPIs-2.6.2.jar]

xmlParserAPIs-2.6.2.jar seem containing a subset of the content xml-apis-1.4.01.jar

From the dependency tree:

- commons-digester 1.6 --> xml-apis-1.4.01.jar

- xom 1.1 ->xmlParserAPIs-2.6.2.jar, xom is a direct dependency in some modules, but also transitive dependency for esapi 2.1.0

Not very clear the usage of xom, we need to check the code to verify for what is used and if can't be avoided, probably check if can excluded xmlParserAPIs-2.6.2.jar as seem a subset of the content xml-apis-1.4.01.jar

--
Jody Garnett

On Wed, 15 Jul 2020 at 09:05, Jody Garnett <[hidden email]> wrote:
That is good news, updating the page to check that as done.

I believe that a good percentage of the split-package issues identified are a result of our war not being strictly defined.

As an example both jrt:/java.xml.ws, javaee-api-7.0.jar both define javax.jws package, I expect it is a mistake that this is included. Marking items like this that we expect to be provided by jetty or tomcat as scope "provided" will ensure they are available when compiling, but not bundled in our war lib folder to cause split-package problems.

Reference: https://stackoverflow.com/questions/48204141/replacements-for-deprecated-jpms-modules-with-java-ee-apis

On Tue, Jul 14, 2020 at 11:23 PM Jose Garcia <[hidden email]> wrote:
Hi Jody

The work for Spring upgrade and JPA upgrade is already merged in the 4.0.x branch.

Regards,
Jose García

On Tue, Jul 14, 2020 at 5:29 PM Jody Garnett <[hidden email]> wrote:
GeoNetwork PSC:

I also rounded up some details from java 11 compatibility testing last week (thanks to David for the initial research).
Java 11 Compatibility
I understand there was work on Spring upgrade and JPA upgrade, how did that go?
--
Jody Garnett
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664

Please consider the environment before printing this email.

Francois Prunayre

Re: sprint results: java 11 compatibility

Hi,

Le lun. 20 juil. 2020 à 09:14, Jose Garcia <[hidden email]> a écrit :

Hi Jody

See inline.

Regards,
Jose García

On Sat, Jul 18, 2020 at 2:17 AM Jody Garnett <[hidden email]> wrote:
I had a first pass at reviewing the dependencies with an evaluation of update, replace, ignore judgement call.

As an example many of the jai-core warnings do not prevent startup and can be ignored.

I have some questions on that page:

ant-1.6.5.jar
- why do we have a build tool included in the war?

hadoop-core-1.0.0.jar
- what is hadoop used for? this is a distributed computing library right ...

This is used in activemq-core 5.6.0 dependency in the messaging module, that is used to index WFS features in ElasticSearch, but not very clear for what is used the JMS messaging. Florent or Francois can provide more details.

When creating WFS features harvester, one idea was to be able to separate this app to the main one. Based on Camel, the harvester could be launched as CLI or run as a webapp. JMS is used to trigger harvesting tasks and is one option for communication between apps in the microservices move we discussed.

Cheers.

Francois

scala-library-2.9.1.jar
- what do we use scala for? scala does not show up as any of the languages used in the repository analytics ....

This is used by the activemq-core 5.6.0 dependency also.

I do not believe we can make substantial progress on this activity until war is fixed (currently contains multiple competing xml apis):

> split package: javax.xml.parsers [jrt:/java.xml, xml-apis-1.4.01.jar, xmlParserAPIs-2.6.2.jar
> ...
> split package: javax.xml.transform.dom [jrt:/java.xml, xml-apis-1.4.01.jar, xmlParserAPIs-2.6.2.jar]

xmlParserAPIs-2.6.2.jar seem containing a subset of the content xml-apis-1.4.01.jar

From the dependency tree:

- commons-digester 1.6 --> xml-apis-1.4.01.jar

- xom 1.1 ->xmlParserAPIs-2.6.2.jar, xom is a direct dependency in some modules, but also transitive dependency for esapi 2.1.0

Not very clear the usage of xom, we need to check the code to verify for what is used and if can't be avoided, probably check if can excluded xmlParserAPIs-2.6.2.jar as seem a subset of the content xml-apis-1.4.01.jar

--
Jody Garnett

On Wed, 15 Jul 2020 at 09:05, Jody Garnett <[hidden email]> wrote:
That is good news, updating the page to check that as done.

I believe that a good percentage of the split-package issues identified are a result of our war not being strictly defined.

As an example both jrt:/java.xml.ws, javaee-api-7.0.jar both define javax.jws package, I expect it is a mistake that this is included. Marking items like this that we expect to be provided by jetty or tomcat as scope "provided" will ensure they are available when compiling, but not bundled in our war lib folder to cause split-package problems.

Reference: https://stackoverflow.com/questions/48204141/replacements-for-deprecated-jpms-modules-with-java-ee-apis

On Tue, Jul 14, 2020 at 11:23 PM Jose Garcia <[hidden email]> wrote:
Hi Jody

The work for Spring upgrade and JPA upgrade is already merged in the 4.0.x branch.

Regards,
Jose García

On Tue, Jul 14, 2020 at 5:29 PM Jody Garnett <[hidden email]> wrote:
GeoNetwork PSC:

I also rounded up some details from java 11 compatibility testing last week (thanks to David for the initial research).
Java 11 Compatibility
I understand there was work on Spring upgrade and JPA upgrade, how did that go?
--
Jody Garnett
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

--
Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664

Please consider the environment before printing this email.

--
Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664

Please consider the environment before printing this email.
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork