patches

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

patches

pcav
Hi all.
There are 5 patches in the trac:

https://trac.osgeo.org/qgis/ticket/1716

https://trac.osgeo.org/qgis/ticket/62

https://trac.osgeo.org/qgis/ticket/1855

https://trac.osgeo.org/qgis/ticket/1863

https://trac.osgeo.org/qgis/ticket/1869

We have applied and tested them (thanks Giovanni), and they seem to work well. I
would suggest to lifte the freeze to include them, unless someone who inspected
the code finds problems. I think the release of 1.2 is an important landmark,
and it would be good to have as many issues fixed as possible.
Any objections?
Thanks.
--
Paolo Cavallini: http://www.faunalia.it/pc
_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer
Reply | Threaded
Open this post in threaded view
|

AW: patches

Hugentobler  Marco
Hi Paolo

>I
>would suggest to lifte the freeze

>I think the release of 1.2 is an important landmark,
>and it would be good to have as many issues fixed as possible.
>Any objections?

It is up to Tim to decide.

My personal opinion: I think it is better to include those new features into 1.3 for stability reasons (that's the purpose of feature freeze after all).

Regards,
Marco

-----Ursprüngliche Nachricht-----
Von: [hidden email] im Auftrag von Paolo Cavallini
Gesendet: Do 13.08.2009 08:11
An: qgis-developer
Betreff: [Qgis-developer] patches
 
Hi all.
There are 5 patches in the trac:

https://trac.osgeo.org/qgis/ticket/1716

https://trac.osgeo.org/qgis/ticket/62

https://trac.osgeo.org/qgis/ticket/1855

https://trac.osgeo.org/qgis/ticket/1863

https://trac.osgeo.org/qgis/ticket/1869

We have applied and tested them (thanks Giovanni), and they seem to work well. I
would suggest to lifte the freeze to include them, unless someone who inspected
the code finds problems. I think the release of 1.2 is an important landmark,
and it would be good to have as many issues fixed as possible.
Any objections?
Thanks.
--
Paolo Cavallini: http://www.faunalia.it/pc
_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer

_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer
Reply | Threaded
Open this post in threaded view
|

Re: AW: patches

pcav
Hugentobler Marco ha scritto:
> My personal opinion: I think it is better to include those new features into 1.3 for stability reasons (that's the purpose of feature freeze after all).

Of course, if you think there is a risk of instability, better to postpone it. I
suggested it because they do not seemed invasive.
All the best.
--
Paolo Cavallini: http://www.faunalia.it/pc
_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer
Reply | Threaded
Open this post in threaded view
|

Re: AW: patches

Giovanni Manghi
In reply to this post by Hugentobler Marco
Hi,

none of them is fundamental, but they fix/add useful things for the
users, so if it is really not a big stability problem I would like (as
user) to see them in 1.2

I tested them and does not seems to me that my compiled copy of qgis is
having stability issues.

thanks

-- Giovanni --


> It is up to Tim to decide.
>
> My personal opinion: I think it is better to include those new features into 1.3 for stability reasons (that's the purpose of feature freeze after all).
>
> Regards,
> Marco
>
> -----Ursprüngliche Nachricht-----
> Von: [hidden email] im Auftrag von Paolo Cavallini
> Gesendet: Do 13.08.2009 08:11
> An: qgis-developer
> Betreff: [Qgis-developer] patches
>  
> Hi all.
> There are 5 patches in the trac:
>
> https://trac.osgeo.org/qgis/ticket/1716
>
> https://trac.osgeo.org/qgis/ticket/62
>
> https://trac.osgeo.org/qgis/ticket/1855
>
> https://trac.osgeo.org/qgis/ticket/1863
>
> https://trac.osgeo.org/qgis/ticket/1869
>
> We have applied and tested them (thanks Giovanni), and they seem to work well. I
> would suggest to lifte the freeze to include them, unless someone who inspected
> the code finds problems. I think the release of 1.2 is an important landmark,
> and it would be good to have as many issues fixed as possible.
> Any objections?
> Thanks.

_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer
Reply | Threaded
Open this post in threaded view
|

Re: patches

Jürgen E. Fischer
In reply to this post by pcav
Hi Paolo,

On Thu, 13. Aug 2009 at 10:29:03 +0200, Paolo Cavallini wrote:
> Hugentobler Marco ha scritto:
> > My personal opinion: I think it is better to include those new features
> > into 1.3 for stability reasons (that's the purpose of feature freeze after
> > all).

> Of course, if you think there is a risk of instability, better to postpone it. I
> suggested it because they do not seemed invasive.

#62 might be very invasive.  Previously there was not explicit type for feature
ids and therefore we might find a lot of places where there are ints now, which
are feature ids, but were not touched because they were not yet identified as
such.  That's a potential source for breakages.

The others IMHO are harmless.  If we weren't in feature freeze, I would have
applied them already.  But they aren't too important either, so I don't see a
urgent need for lifting the feature freeze just for those.

Jürgen

--
Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-20
Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
Software Engineer         D-26506 Norden               http://www.norbit.de

--
norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH
Rheinstrasse 13, 26506 Norden
GF: Jelto Buurman, HR: Amtsgericht Emden, HRB 5502

_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer
Reply | Threaded
Open this post in threaded view
|

Re: patches

Carlos Dávila
In reply to this post by pcav

Jürgen E. Fischer escribió:

> Hi Paolo,
>
> On Thu, 13. Aug 2009 at 10:29:03 +0200, Paolo Cavallini wrote:
>  
>> Hugentobler Marco ha scritto:
>>    
>>> My personal opinion: I think it is better to include those new features
>>> into 1.3 for stability reasons (that's the purpose of feature freeze after
>>> all).
>>>      
>
>  
>> Of course, if you think there is a risk of instability, better to postpone it. I
>> suggested it because they do not seemed invasive.
>>    
>
> #62 might be very invasive.  Previously there was not explicit type for feature
> ids and therefore we might find a lot of places where there are ints now, which
> are feature ids, but were not touched because they were not yet identified as
> such.  That's a potential source for breakages.
>
> The others IMHO are harmless.  If we weren't in feature freeze, I would have
> applied them already.  But they aren't too important either, so I don't see a
> urgent need for lifting the feature freeze just for those.
>  
Could you consider to commit also the patch I sent a few days ago to
this list that introduces some strings from fTools for translation. I
think it shouldn't break anything and will improve internationalization
of 1.2 release.
Regards
Carlos
> Jürgen
>
>  


--
Por favor, no me envíe documentos con extensiones .doc, .docx, .xls, .xlsx, .ppt, .pptx, .mdb, mdbx

Instale OpenOffice desde http://es.openoffice.org/programa/index.html
OpenOffice es libre: se puede copiar, modificar y redistribuir libremente. Gratis y totalmente legal.
OpenOffice funciona mejor que otros paquetes de oficina.
OpenOffice está en continuo desarrollo y no tendrá que pagar por las nuevas versiones.




--
Por favor, no me envíe documentos con extensiones .doc, .docx, .xls, .xlsx, .ppt, .pptx, .mdb, mdbx

Instale OpenOffice desde http://es.openoffice.org/programa/index.html
OpenOffice es libre: se puede copiar, modificar y redistribuir libremente. Gratis y totalmente legal.
OpenOffice funciona mejor que otros paquetes de oficina.
OpenOffice está en continuo desarrollo y no tendrá que pagar por las nuevas versiones.

_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer
Reply | Threaded
Open this post in threaded view
|

Re: patches

Tim Sutton-4
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

Carlos Dávila wrote:

> Jürgen E. Fischer escribió:
>> Hi Paolo,
>>
>> On Thu, 13. Aug 2009 at 10:29:03 +0200, Paolo Cavallini wrote:
>>  
>>> Hugentobler Marco ha scritto:
>>>    
>>>> My personal opinion: I think it is better to include those new features
>>>> into 1.3 for stability reasons (that's the purpose of feature freeze after
>>>> all).
>>>>      
>>  
>>> Of course, if you think there is a risk of instability, better to postpone it. I
>>> suggested it because they do not seemed invasive.
>>>    
>> #62 might be very invasive.  Previously there was not explicit type for feature
>> ids and therefore we might find a lot of places where there are ints now, which
>> are feature ids, but were not touched because they were not yet identified as
>> such.  That's a potential source for breakages.
>>
>> The others IMHO are harmless.  If we weren't in feature freeze, I would have
>> applied them already.  But they aren't too important either, so I don't see a
>> urgent need for lifting the feature freeze just for those.
>>  
> Could you consider to commit also the patch I sent a few days ago to
> this list that introduces some strings from fTools for translation. I
> think it shouldn't break anything and will improve internationalization
> of 1.2 release.
> Regards
> Carlos
>> Jürgen
>>
>>  
>
>

I think we should wait with these other mentioned patches for 1.3. It
should be fine to commit Carlos' patch it it relates only to translations.

I will be calling for translations tomorrow evening late (South African
time) after which now more string changes should be introduced.

Regards





- --

Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
==============================================
Please do not email me off-list with technical
support questions. Using the lists will gain
more exposure for your issues and the knowledge
surrounding your issue will be shared with all.

Visit http://linfiniti.com to find out about:
 * QGIS programming and support services
 * Mapserver and PostGIS based hosting plans
 * FOSS Consulting Services
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
==============================================

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqEiXAACgkQqk07qZdiYjfVAQCgpTbvRqXAu397C2+pLGyJVDzS
jokAoIrCOFXNwEAKCzy1Q8U82L1DVN6M
=HITd
-----END PGP SIGNATURE-----
_______________________________________________
Qgis-developer mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/qgis-developer