ossimRpcSolver.cpp: license and precision issue with NITF RPC00B

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

ossimRpcSolver.cpp: license and precision issue with NITF RPC00B

Even Rouault-2

Hi,

 

I understand there has been a license change from LGPL to MIT some time ago, but I'm confused by the state of the repositories

 

SVN seems to have been deprecated but

https://svn.osgeo.org/ossim/trunk/ossim/src/ossim/projection/ossimRpcSolver.cpp has the MIT license mentionned (it is also the license used in the official ossim-1.8.20-3.tar.gz release)

 

Whereas https://raw.githubusercontent.com/ossimlabs/ossim/master/src/projection/ossimRpcSolver.cpp mentions LGPL and an older date.

 

Both files are identical apart the header.

 

So it seems that the GIT migration wouldn't have been done from the latest state of SVN ?

 

Now a more functional question. I have RPC that I want to write into NITF RPC00B TRE. ossimRpcSolver::getNitfRpcBTag() "just" takes the values from the object, casting for example the X/Y offset and scale values to integers since that's a limitation of the RPC00B TRE. Meanwhile that looses precision. I'm considering modifying ossimRpcSolver::solveCoefficients() to take into account right at the beginning the rounding constraints of the RPC00B TRE for the 10 scale and offset values, before computing the remaining 2x39 coefficients of the rational polynomials, that way the final accuracy will be better. Actually my issue is that my input is already a RPC, not necesseraly generated by ossimRpcSolver, so I'm considering using it to generate a set of control points, that I would reinject in the modified solver. Has anyone faced this issue before? Any other way of addressing it ?

 

Thanks,

 

Even

 

--

Spatialys - Geospatial professional services

http://www.spatialys.com


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
www.ossim.org
Ossim-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/ossim-developer
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: ossimRpcSolver.cpp: license and precision issue with NITF RPC00B

David Burken-2
Hi Even,

Everything should be MIT.  We need to fix the headers.  I've been flipping them as I open.  I think the git repo got migrated prematurely.

On the rpc solver I have no experience with it.  Your approach sounds good though.

Take care,
Dave


On 12/20/2016 07:38 AM, Even Rouault wrote:

Hi,

 

I understand there has been a license change from LGPL to MIT some time ago, but I'm confused by the state of the repositories

 

SVN seems to have been deprecated but

https://svn.osgeo.org/ossim/trunk/ossim/src/ossim/projection/ossimRpcSolver.cpp has the MIT license mentionned (it is also the license used in the official ossim-1.8.20-3.tar.gz release)

 

Whereas https://raw.githubusercontent.com/ossimlabs/ossim/master/src/projection/ossimRpcSolver.cpp mentions LGPL and an older date.

 

Both files are identical apart the header.

 

So it seems that the GIT migration wouldn't have been done from the latest state of SVN ?

 

Now a more functional question. I have RPC that I want to write into NITF RPC00B TRE. ossimRpcSolver::getNitfRpcBTag() "just" takes the values from the object, casting for example the X/Y offset and scale values to integers since that's a limitation of the RPC00B TRE. Meanwhile that looses precision. I'm considering modifying ossimRpcSolver::solveCoefficients() to take into account right at the beginning the rounding constraints of the RPC00B TRE for the 10 scale and offset values, before computing the remaining 2x39 coefficients of the rational polynomials, that way the final accuracy will be better. Actually my issue is that my input is already a RPC, not necesseraly generated by ossimRpcSolver, so I'm considering using it to generate a set of control points, that I would reinject in the modified solver. Has anyone faced this issue before? Any other way of addressing it ?

 

Thanks,

 

Even

 

--

Spatialys - Geospatial professional services

http://www.spatialys.com



------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel


_______________________________________________
www.ossim.org
Ossim-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/ossim-developer


------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
www.ossim.org
Ossim-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/ossim-developer
Loading...