itowns2 release candidate discussion

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

itowns2 release candidate discussion

Alexandre Devaux
Hi all!

We are very close to launch a release candidate. Some important PR are still in work/test but one of the most important subject is now the API, which is in the middle of many discussions.


It seems we don't all (developers) have the exact same point of view for now:)

- As for now, iTowns leave access to a large part of the code as methods are usually not private. -> not good
- High level API is too messy and not generic enough. -> not good

We need to agree on the methods available from the API, usable for non professional users and coders but also protect method that should not be accessible directly.



A first proposition:
Remove ApiGlobe and replace it by a Viewer and a Map with generic methods.
Map could be plan, ellipsoidal or any other format.
Methods that should be in the High level api for the candidate release:

 addImageryLayer / removeImageryLayer
 addElevationLayer / removeElevationLayer
 addFeatureLayer  / removeFeatureLayer

 setLayerVisibility
 setLayerOpacity

 moveLayerUp
 moveLayerDown
 moveLayerToIndex

 getCenter
 getRange
 getHeading
 getTilt
 getCameraLocation
 pan
 setCenter   
 setHeading
 setTilt
 setRange
 resetHeading
 resetTilt
 setAnimationEnabled
 isAnimationEnabled


Bye!
Alexandre

-- 
Alexandre Devaux
Chargé d'Etudes et de Recherche
Laboratoire MATIS, IGN
Tel: 01 43 98 85 73

_______________________________________________
iTowns-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/itowns-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: itowns2 release candidate discussion

Alexandre Devaux
I forgot! let's discuss it directly here:

https://github.com/iTowns/itowns2/issues/272https://github.com/iTowns/itowns2/issues/272

Bests,
-- 
Alexandre Devaux
Chargé d'Etudes et de Recherche
Laboratoire MATIS, IGN
Tel: 01 43 98 85 73

De : Alexandre Devaux
Date d'envoi : mercredi 15 mars 2017 11:15
À : [hidden email]
Objet : itowns2 release candidate discussion

Hi all!

We are very close to launch a release candidate. Some important PR are still in work/test but one of the most important subject is now the API, which is in the middle of many discussions.


It seems we don't all (developers) have the exact same point of view for now:)

- As for now, iTowns leave access to a large part of the code as methods are usually not private. -> not good
- High level API is too messy and not generic enough. -> not good

We need to agree on the methods available from the API, usable for non professional users and coders but also protect method that should not be accessible directly.



A first proposition:
Remove ApiGlobe and replace it by a Viewer and a Map with generic methods.
Map could be plan, ellipsoidal or any other format.
Methods that should be in the High level api for the candidate release:

 addImageryLayer / removeImageryLayer
 addElevationLayer / removeElevationLayer
 addFeatureLayer  / removeFeatureLayer

 setLayerVisibility
 setLayerOpacity

 moveLayerUp
 moveLayerDown
 moveLayerToIndex

 getCenter
 getRange
 getHeading
 getTilt
 getCameraLocation
 pan
 setCenter   
 setHeading
 setTilt
 setRange
 resetHeading
 resetTilt
 setAnimationEnabled
 isAnimationEnabled


Bye!
Alexandre

-- 
Alexandre Devaux
Chargé d'Etudes et de Recherche
Laboratoire MATIS, IGN
Tel: 01 43 98 85 73

_______________________________________________
iTowns-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/itowns-dev
Loading...