[gdal-dev] r 39092: vsigzip filesize check

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[gdal-dev] r 39092: vsigzip filesize check

Kurt Schwehr-2
Even,

With https://trac.osgeo.org/gdal/changeset/39092, can you explain the this check?

    uncompressed_pos - startOff > m_compressed_size

That looks to be comparing the number of bytes compressed vrs uncompressed.  How is this checking that the filesize changed?  Something seems wrong or there needs to be a comment somewhere because this doesn't seem correct.

Thanks,
-kurt

_______________________________________________
gdal-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/gdal-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: r 39092: vsigzip filesize check

Even Rouault-2

On vendredi 16 juin 2017 05:40:53 CEST Kurt Schwehr wrote:

> Even,

>

> With https://trac.osgeo.org/gdal/changeset/39092, can you explain the this

> check?

>

> uncompressed_pos - startOff > m_compressed_size

>

> That looks to be comparing the number of bytes compressed vrs

> uncompressed. How is this checking that the filesize changed? Something

> seems wrong or there needs to be a comment somewhere because this doesn't

> seem correct.

 

uncompressed_pos was badly named indeed. It was the "raw" position in the compressed file actually. Fixed per

https://trac.osgeo.org/gdal/changeset/39136

 

>

> Thanks,

> -kurt

 

 

--

Spatialys - Geospatial professional services

http://www.spatialys.com


_______________________________________________
gdal-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/gdal-dev
Loading...