VS Studio Help?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

VS Studio Help?

Paul Ramsey
We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?

https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96

Thanks!

P
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

andrew.bell.ia@gmail.com

On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?

https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96

Thanks!

P
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel


--
Andrew Bell
[hidden email]

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

Paul Ramsey
That maybe was a lot of them? I put actual headers into place where a std::vector<std::unique_ptr<>> was being declared, but I'm still left with

https://dev.azure.com/libgeos/geos/_build/results?buildId=591&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=156

and a handful of others. The error seems the same, but I've already brought in the class defn, not sure what else to do...

P

> On Jul 31, 2020, at 10:51 AM, Andrew Bell <[hidden email]> wrote:
>
> https://stackoverflow.com/questions/34627874/c11-container-of-unique-ptr-of-forward-declared-class
>
> On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
> We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?
>
> https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96
>
> Thanks!
>
> P
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel
>
>
> --
> Andrew Bell
> [hidden email]
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

Paul Ramsey
Er, here's the line it's complaining about.

https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65

> On Jul 31, 2020, at 12:27 PM, Paul Ramsey <[hidden email]> wrote:
>
> That maybe was a lot of them? I put actual headers into place where a std::vector<std::unique_ptr<>> was being declared, but I'm still left with
>
> https://dev.azure.com/libgeos/geos/_build/results?buildId=591&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=156
>
> and a handful of others. The error seems the same, but I've already brought in the class defn, not sure what else to do...
>
> P
>
>> On Jul 31, 2020, at 10:51 AM, Andrew Bell <[hidden email]> wrote:
>>
>> https://stackoverflow.com/questions/34627874/c11-container-of-unique-ptr-of-forward-declared-class
>>
>> On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
>> We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?
>>
>> https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96
>>
>> Thanks!
>>
>> P
>> _______________________________________________
>> geos-devel mailing list
>> [hidden email]
>> https://lists.osgeo.org/mailman/listinfo/geos-devel
>>
>>
>> --
>> Andrew Bell
>> [hidden email]
>> _______________________________________________
>> geos-devel mailing list
>> [hidden email]
>> https://lists.osgeo.org/mailman/listinfo/geos-devel
>

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

andrew.bell.ia@gmail.com
The CoordinateSequence there doesn't appear to be in the correct namespace. Seems like you would need geom::CoordinateSequence.  

On Fri, Jul 31, 2020 at 3:34 PM Paul Ramsey <[hidden email]> wrote:
Er, here's the line it's complaining about.

https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65

> On Jul 31, 2020, at 12:27 PM, Paul Ramsey <[hidden email]> wrote:
>
> That maybe was a lot of them? I put actual headers into place where a std::vector<std::unique_ptr<>> was being declared, but I'm still left with
>
> https://dev.azure.com/libgeos/geos/_build/results?buildId=591&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=156
>
> and a handful of others. The error seems the same, but I've already brought in the class defn, not sure what else to do...
>
> P
>
>> On Jul 31, 2020, at 10:51 AM, Andrew Bell <[hidden email]> wrote:
>>
>> https://stackoverflow.com/questions/34627874/c11-container-of-unique-ptr-of-forward-declared-class
>>
>> On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
>> We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?
>>
>> https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96
>>
>> Thanks!
>>
>> P
>> _______________________________________________
>> geos-devel mailing list
>> [hidden email]
>> https://lists.osgeo.org/mailman/listinfo/geos-devel
>>
>>
>> --
>> Andrew Bell
>> [hidden email]
>> _______________________________________________
>> geos-devel mailing list
>> [hidden email]
>> https://lists.osgeo.org/mailman/listinfo/geos-devel
>

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel


--
Andrew Bell
[hidden email]

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

Paul Ramsey
Bringing in the namespace did not seem to be the trick.

https://dev.azure.com/libgeos/geos/_build/results?buildId=596&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=1064

https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65

Still mysterious to me.

P

> On Jul 31, 2020, at 2:03 PM, Andrew Bell <[hidden email]> wrote:
>
> The CoordinateSequence there doesn't appear to be in the correct namespace. Seems like you would need geom::CoordinateSequence.  
>
> On Fri, Jul 31, 2020 at 3:34 PM Paul Ramsey <[hidden email]> wrote:
> Er, here's the line it's complaining about.
>
> https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65
>
> > On Jul 31, 2020, at 12:27 PM, Paul Ramsey <[hidden email]> wrote:
> >
> > That maybe was a lot of them? I put actual headers into place where a std::vector<std::unique_ptr<>> was being declared, but I'm still left with
> >
> > https://dev.azure.com/libgeos/geos/_build/results?buildId=591&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=156
> >
> > and a handful of others. The error seems the same, but I've already brought in the class defn, not sure what else to do...
> >
> > P
> >
> >> On Jul 31, 2020, at 10:51 AM, Andrew Bell <[hidden email]> wrote:
> >>
> >> https://stackoverflow.com/questions/34627874/c11-container-of-unique-ptr-of-forward-declared-class
> >>
> >> On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
> >> We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?
> >>
> >> https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96
> >>
> >> Thanks!
> >>
> >> P
> >> _______________________________________________
> >> geos-devel mailing list
> >> [hidden email]
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >>
> >>
> >> --
> >> Andrew Bell
> >> [hidden email]
> >> _______________________________________________
> >> geos-devel mailing list
> >> [hidden email]
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >
>
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel
>
>
> --
> Andrew Bell
> [hidden email]
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

andrew.bell.ia@gmail.com
I've got this fixed. I'll push something tomorrow.

On Sun, Aug 2, 2020 at 1:23 PM Paul Ramsey <[hidden email]> wrote:
Bringing in the namespace did not seem to be the trick.

https://dev.azure.com/libgeos/geos/_build/results?buildId=596&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=1064

https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65

Still mysterious to me.

P

> On Jul 31, 2020, at 2:03 PM, Andrew Bell <[hidden email]> wrote:
>
> The CoordinateSequence there doesn't appear to be in the correct namespace. Seems like you would need geom::CoordinateSequence. 
>
> On Fri, Jul 31, 2020 at 3:34 PM Paul Ramsey <[hidden email]> wrote:
> Er, here's the line it's complaining about.
>
> https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65
>
> > On Jul 31, 2020, at 12:27 PM, Paul Ramsey <[hidden email]> wrote:
> >
> > That maybe was a lot of them? I put actual headers into place where a std::vector<std::unique_ptr<>> was being declared, but I'm still left with
> >
> > https://dev.azure.com/libgeos/geos/_build/results?buildId=591&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=156
> >
> > and a handful of others. The error seems the same, but I've already brought in the class defn, not sure what else to do...
> >
> > P
> >
> >> On Jul 31, 2020, at 10:51 AM, Andrew Bell <[hidden email]> wrote:
> >>
> >> https://stackoverflow.com/questions/34627874/c11-container-of-unique-ptr-of-forward-declared-class
> >>
> >> On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
> >> We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?
> >>
> >> https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96
> >>
> >> Thanks!
> >>
> >> P
> >> _______________________________________________
> >> geos-devel mailing list
> >> [hidden email]
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >>
> >>
> >> --
> >> Andrew Bell
> >> [hidden email]
> >> _______________________________________________
> >> geos-devel mailing list
> >> [hidden email]
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >
>
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel
>
>
> --
> Andrew Bell
> [hidden email]
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel


--
Andrew Bell
[hidden email]

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: VS Studio Help?

Paul Ramsey
Thank you!!!
I see this pattern in other parts of the code base, I just never understood it.

On Sun, Aug 2, 2020 at 4:04 PM Andrew Bell <[hidden email]> wrote:
I've got this fixed. I'll push something tomorrow.

On Sun, Aug 2, 2020 at 1:23 PM Paul Ramsey <[hidden email]> wrote:
Bringing in the namespace did not seem to be the trick.

https://dev.azure.com/libgeos/geos/_build/results?buildId=596&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=1064

https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65

Still mysterious to me.

P

> On Jul 31, 2020, at 2:03 PM, Andrew Bell <[hidden email]> wrote:
>
> The CoordinateSequence there doesn't appear to be in the correct namespace. Seems like you would need geom::CoordinateSequence. 
>
> On Fri, Jul 31, 2020 at 3:34 PM Paul Ramsey <[hidden email]> wrote:
> Er, here's the line it's complaining about.
>
> https://github.com/libgeos/geos/blob/master/include/geos/operation/overlayng/OverlayGraph.h#L65
>
> > On Jul 31, 2020, at 12:27 PM, Paul Ramsey <[hidden email]> wrote:
> >
> > That maybe was a lot of them? I put actual headers into place where a std::vector<std::unique_ptr<>> was being declared, but I'm still left with
> >
> > https://dev.azure.com/libgeos/geos/_build/results?buildId=591&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96&l=156
> >
> > and a handful of others. The error seems the same, but I've already brought in the class defn, not sure what else to do...
> >
> > P
> >
> >> On Jul 31, 2020, at 10:51 AM, Andrew Bell <[hidden email]> wrote:
> >>
> >> https://stackoverflow.com/questions/34627874/c11-container-of-unique-ptr-of-forward-declared-class
> >>
> >> On Fri, Jul 31, 2020 at 12:26 PM Paul Ramsey <[hidden email]> wrote:
> >> We've got a CI failure in MSVC and it's totally opaque. Anyone have a MSVC build environment and ability to look at what's up?
> >>
> >> https://dev.azure.com/libgeos/geos/_build/results?buildId=585&view=logs&j=305851a9-a7bb-55db-0042-7e2b6f48aa1c&t=7382dcd6-bc22-5ed4-59fb-7b403df8dc96
> >>
> >> Thanks!
> >>
> >> P
> >> _______________________________________________
> >> geos-devel mailing list
> >> [hidden email]
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >>
> >>
> >> --
> >> Andrew Bell
> >> [hidden email]
> >> _______________________________________________
> >> geos-devel mailing list
> >> [hidden email]
> >> https://lists.osgeo.org/mailman/listinfo/geos-devel
> >
>
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel
>
>
> --
> Andrew Bell
> [hidden email]
> _______________________________________________
> geos-devel mailing list
> [hidden email]
> https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel


--
Andrew Bell
[hidden email]
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel