TimeSeries - LayerControl conflict

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

TimeSeries - LayerControl conflict

Stefano Menegon-2
Hi all,

 I think there is a conflict between LayersControl and TimeSeries.

If the Context document contains the wmc:Extension tag (as using timeseries widget),
LayerControls expects a wmc:GroupList tag as child of wmc:Extension.
In this case wmc:GroupList dosen't exist, so LayersControl's output is empty!

A patch should be:

#svn diff LayerControl.xsl
Index: LayerControl.xsl
===================================================================
--- LayerControl.xsl    (revision 3996)
+++ LayerControl.xsl    (working copy)
@@ -57,12 +57,12 @@
   <xsl:template match="/wmc:ViewContext">
     <div>
       <div class="layerControl">
-        <xsl:if test="wmc:General/wmc:Extension">
+        <xsl:if test="wmc:General/wmc:Extension/wmc:GroupList">
                      <xsl:apply-templates select="wmc:General/wmc:Extension/wmc:GroupList/wmc:Group">
                                <xsl:sort select="position()" order="ascending" data-type="number"/>
                          </xsl:apply-templates>
                </xsl:if>
-        <xsl:if test="not(wmc:General/wmc:Extension)">
+        <xsl:if test="not(wmc:General/wmc:Extension/wmc:GroupList)">
                          <xsl:apply-templates select="wmc:LayerList/wmc:Layer">
                                          <xsl:sort select="position()" order="descending" data-type="number"/>
                          </xsl:apply-templates>


Regards,
--
Stefano Menegon

-------------------------------------------------------------------------
Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
Studies have shown that voting for your favorite open source project,
along with a healthy diet, reduces your potential for chronic lameness
and boredom. Vote Now at http://www.sourceforge.net/community/cca08
_______________________________________________
mapbuilder-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeSeries - LayerControl conflict

Andreas Hocevar
Stefano,

thanks for your patch! If you have a minute, could you please create a
ticket at http://jira.codehaus.org/browse/MAP ?

If not, please drop me a line, then I will do the ticket work for you
and apply your patch to trunk.

Thanks!
Andreas.

On Tue, Jul 8, 2008 at 3:29 PM, Stefano Menegon <[hidden email]> wrote:

> Hi all,
>
>  I think there is a conflict between LayersControl and TimeSeries.
>
> If the Context document contains the wmc:Extension tag (as using timeseries widget),
> LayerControls expects a wmc:GroupList tag as child of wmc:Extension.
> In this case wmc:GroupList dosen't exist, so LayersControl's output is empty!
>
> A patch should be:
>
> #svn diff LayerControl.xsl
> Index: LayerControl.xsl
> ===================================================================
> --- LayerControl.xsl    (revision 3996)
> +++ LayerControl.xsl    (working copy)
> @@ -57,12 +57,12 @@
>   <xsl:template match="/wmc:ViewContext">
>     <div>
>       <div class="layerControl">
> -        <xsl:if test="wmc:General/wmc:Extension">
> +        <xsl:if test="wmc:General/wmc:Extension/wmc:GroupList">
>                      <xsl:apply-templates select="wmc:General/wmc:Extension/wmc:GroupList/wmc:Group">
>                                <xsl:sort select="position()" order="ascending" data-type="number"/>
>                          </xsl:apply-templates>
>                </xsl:if>
> -        <xsl:if test="not(wmc:General/wmc:Extension)">
> +        <xsl:if test="not(wmc:General/wmc:Extension/wmc:GroupList)">
>                          <xsl:apply-templates select="wmc:LayerList/wmc:Layer">
>                                          <xsl:sort select="position()" order="descending" data-type="number"/>
>                          </xsl:apply-templates>
>
>
> Regards,
> --
> Stefano Menegon
>
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> _______________________________________________
> mapbuilder-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
mapbuilder-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeSeries - LayerControl conflict

Stefano Menegon-2
Andreas.

I have raised a JIRA issue:

http://jira.codehaus.org/browse/MAP-552

--
Stefano

On Tue, Jul 15, 2008 at 02:07:44PM +0200, Andreas Hocevar wrote:

> Stefano,
>
> thanks for your patch! If you have a minute, could you please create a
> ticket at http://jira.codehaus.org/browse/MAP ?
>
> If not, please drop me a line, then I will do the ticket work for you
> and apply your patch to trunk.
>
> Thanks!
> Andreas.
>
> On Tue, Jul 8, 2008 at 3:29 PM, Stefano Menegon <[hidden email]> wrote:
> > Hi all,
> >
> >  I think there is a conflict between LayersControl and TimeSeries.
> >
> > If the Context document contains the wmc:Extension tag (as using timeseries widget),
> > LayerControls expects a wmc:GroupList tag as child of wmc:Extension.
> > In this case wmc:GroupList dosen't exist, so LayersControl's output is empty!
> >
> > A patch should be:
> >
> > #svn diff LayerControl.xsl
> > Index: LayerControl.xsl
> > ===================================================================
> > --- LayerControl.xsl    (revision 3996)
> > +++ LayerControl.xsl    (working copy)
> > @@ -57,12 +57,12 @@
> >   <xsl:template match="/wmc:ViewContext">
> >     <div>
> >       <div class="layerControl">
> > -        <xsl:if test="wmc:General/wmc:Extension">
> > +        <xsl:if test="wmc:General/wmc:Extension/wmc:GroupList">
> >                      <xsl:apply-templates select="wmc:General/wmc:Extension/wmc:GroupList/wmc:Group">
> >                                <xsl:sort select="position()" order="ascending" data-type="number"/>
> >                          </xsl:apply-templates>
> >                </xsl:if>
> > -        <xsl:if test="not(wmc:General/wmc:Extension)">
> > +        <xsl:if test="not(wmc:General/wmc:Extension/wmc:GroupList)">
> >                          <xsl:apply-templates select="wmc:LayerList/wmc:Layer">
> >                                          <xsl:sort select="position()" order="descending" data-type="number"/>
> >                          </xsl:apply-templates>
> >
> >
> > Regards,
> > --
> > Stefano Menegon
> >
> > -------------------------------------------------------------------------
> > Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> > Studies have shown that voting for your favorite open source project,
> > along with a healthy diet, reduces your potential for chronic lameness
> > and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> > _______________________________________________
> > mapbuilder-devel mailing list
> > [hidden email]
> > https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
> >
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> mapbuilder-devel mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
mapbuilder-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: TimeSeries - LayerControl conflict

Andreas Hocevar
Hi,

On Tue, Jul 15, 2008 at 4:48 PM, Stefano Menegon <[hidden email]> wrote:
> http://jira.codehaus.org/browse/MAP-552

This is now fixed in trunk.

Regards,
Andreas.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
mapbuilder-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mapbuilder-devel
Loading...