Ticket #918

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Ticket #918

Jackie Ng
Hi All,

I've created a patch for ticket 918.

https://trac.osgeo.org/fdo/ticket/918

This issue is currently blocking my ability to release MapGuide Open Source 3.1

Please review. Thanks.

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Ticket #918

Greg Boone
The patch looks good.

Greg

Sent from my iPhone

On May 23, 2016, at 12:49 PM, Jackie Ng <[hidden email]> wrote:

Hi All,

I've created a patch for ticket 918.

https://trac.osgeo.org/fdo/ticket/918

This issue is currently blocking my ability to release MapGuide Open Source
3.1

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Ticket-918-tp5267817.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
Reply | Threaded
Open this post in threaded view
|

Re: Ticket #918

Johan Van de Wauw
Looks good.

For your info: adding -z defs to ld or -Wl,-z,defs to gcc would have
detected this.

Kind Regards,
Johan

On Mon, May 23, 2016 at 11:41 PM, Greg Boone <[hidden email]> wrote:

> The patch looks good.
>
> Greg
>
> Sent from my iPhone
>
> On May 23, 2016, at 12:49 PM, Jackie Ng <[hidden email]> wrote:
>
> Hi All,
>
> I've created a patch for ticket 918.
>
> https://trac.osgeo.org/fdo/ticket/918
>
> This issue is currently blocking my ability to release MapGuide Open Source
> 3.1
>
> Please review. Thanks.
>
> - Jackie
>
>
>
> --
> View this message in context: http://osgeo-org.1560.x6.nabble.com/Ticket-918-tp5267817.html
> Sent from the FDO Internals mailing list archive at Nabble.com.
> _______________________________________________
> fdo-internals mailing list
> [hidden email]
> http://lists.osgeo.org/mailman/listinfo/fdo-internals
> _______________________________________________
> fdo-internals mailing list
> [hidden email]
> http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
Reply | Threaded
Open this post in threaded view
|

Re: Ticket #918

Jackie Ng
Hi Johan,

Is this something you would stick into CXXFLAGS of configure.in?

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Ticket #918

Johan Van de Wauw
correct place would be LDFLAGS . You can add it when using ./configure
or add it in configure.in

so

export LDFLAGS=-z defs
./configure

or add
LDFLAGS +=-z defs
to configure.in

I'm on a conference - so I haven't tested this, but should work.

Kind Regards,
Johan

On Tue, May 24, 2016 at 2:22 PM, Jackie Ng <[hidden email]> wrote:

> Hi Johan,
>
> Is this something you would stick into CXXFLAGS of configure.in?
>
> - Jackie
>
>
>
> --
> View this message in context: http://osgeo-org.1560.x6.nabble.com/Ticket-918-tp5267817p5267956.html
> Sent from the FDO Internals mailing list archive at Nabble.com.
> _______________________________________________
> fdo-internals mailing list
> [hidden email]
> http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
Reply | Threaded
Open this post in threaded view
|

Re: Ticket #918

Johan Van de Wauw
I did a quick check and the CMakelists.txt in the same dir also misses a file.


On Tue, May 24, 2016 at 3:09 PM, Johan Van de Wauw
<[hidden email]> wrote:

> correct place would be LDFLAGS . You can add it when using ./configure
> or add it in configure.in
>
> so
>
> export LDFLAGS=-z defs
> ./configure
>
> or add
> LDFLAGS +=-z defs
> to configure.in
>
> I'm on a conference - so I haven't tested this, but should work.
>
> Kind Regards,
> Johan
>
> On Tue, May 24, 2016 at 2:22 PM, Jackie Ng <[hidden email]> wrote:
>> Hi Johan,
>>
>> Is this something you would stick into CXXFLAGS of configure.in?
>>
>> - Jackie
>>
>>
>>
>> --
>> View this message in context: http://osgeo-org.1560.x6.nabble.com/Ticket-918-tp5267817p5267956.html
>> Sent from the FDO Internals mailing list archive at Nabble.com.
>> _______________________________________________
>> fdo-internals mailing list
>> [hidden email]
>> http://lists.osgeo.org/mailman/listinfo/fdo-internals

_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals

cmake-wms.patch (762 bytes) Download Attachment