Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Sandro Santilli-4
On Wed, Feb 20, 2019 at 12:59:46PM -0800, [hidden email] wrote:

> - * Last port: algorithm/InteriorPointArea.java r728 (JTS-1.13+)
> + * Last port: algorithm/InteriorPointArea.java (JTS-1.17+)
> + * https://github.com/locationtech/jts/commit/a140ca30cc51be4f65c950a30b0a8f51a6df75ba

May I suggest to include the short commit hash on the same line as "Last port" ?
It would help using with grep. Syntax could be something like:

 * Last port: algorithm/InteriorPointArea.java a140ca30 (JTS-1.17+)

Having full url to the official repository is also good

--strk;
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Martin Davis-3
Right, I can see why that would be useful.  I was worried that using a short hashlet might not be unique [1].  But can easily do both I guess.  Or maybe just a concern for future generations.


On Thu, Feb 21, 2019 at 2:20 AM Sandro Santilli <[hidden email]> wrote:
On Wed, Feb 20, 2019 at 12:59:46PM -0800, [hidden email] wrote:

> - * Last port: algorithm/InteriorPointArea.java r728 (JTS-1.13+)
> + * Last port: algorithm/InteriorPointArea.java (JTS-1.17+)
> + * https://github.com/locationtech/jts/commit/a140ca30cc51be4f65c950a30b0a8f51a6df75ba

May I suggest to include the short commit hash on the same line as "Last port" ?
It would help using with grep. Syntax could be something like:

 * Last port: algorithm/InteriorPointArea.java a140ca30 (JTS-1.17+)

Having full url to the official repository is also good

--strk;

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Paul Ramsey
I’ve been putting dates YYYY-MM-DD into the headers on the ones I’ve been doing. Avoids system dependence and version numbering.
P

On Feb 21, 2019, at 7:55 AM, Martin Davis <[hidden email]> wrote:

Right, I can see why that would be useful.  I was worried that using a short hashlet might not be unique [1].  But can easily do both I guess.  Or maybe just a concern for future generations.


On Thu, Feb 21, 2019 at 2:20 AM Sandro Santilli <[hidden email]> wrote:
On Wed, Feb 20, 2019 at 12:59:46PM -0800, [hidden email] wrote:

> - * Last port: algorithm/InteriorPointArea.java r728 (JTS-1.13+)
> + * Last port: algorithm/InteriorPointArea.java (JTS-1.17+)
> + * https://github.com/locationtech/jts/commit/a140ca30cc51be4f65c950a30b0a8f51a6df75ba

May I suggest to include the short commit hash on the same line as "Last port" ?
It would help using with grep. Syntax could be something like:

 * Last port: algorithm/InteriorPointArea.java a140ca30 (JTS-1.17+)

Having full url to the official repository is also good

--strk;
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel


_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Sandro Santilli-4
On Thu, Feb 21, 2019 at 08:10:33AM -0800, Paul Ramsey wrote:
> I’ve been putting dates YYYY-MM-DD into the headers on the ones I’ve been doing. Avoids system dependence and version numbering.

Date is also nice, and that human-readable version
The more refs we have, the better :)

But the very detailed revision (svn revision, or git hash)
helps in spotting _exact_ difference.

--strk;
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Martin Davis-3
So we understand, what is the use case here?  Are you grepping to find all GEOS files which were changed from a given JTS commit?    

If so, do you want any extra tag for the hashlet?   Give us an example of the standard form...

On Thu, Feb 21, 2019 at 8:46 AM Sandro Santilli <[hidden email]> wrote:
On Thu, Feb 21, 2019 at 08:10:33AM -0800, Paul Ramsey wrote:
> I’ve been putting dates YYYY-MM-DD into the headers on the ones I’ve been doing. Avoids system dependence and version numbering.

Date is also nice, and that human-readable version
The more refs we have, the better :)

But the very detailed revision (svn revision, or git hash)
helps in spotting _exact_ difference.

--strk;
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Sandro Santilli-4
On Thu, Feb 21, 2019 at 10:32:48AM -0800, Martin Davis wrote:
> So we understand, what is the use case here?  Are you grepping to find all
> GEOS files which were changed from a given JTS commit?
>
> If so, do you want any extra tag for the hashlet?   Give us an example of
> the standard form...

Use case is: to get a feel of which files were ported when, I grep
for 'Last Port' in all files.

Works better with SVN revisions and dates and human readable versions
than with hashes indeed, so feel free to leave the hash where it is :)

--strk;
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [geos-commits] [SCM] GEOS branch master updated. edc36747409058cb10aeb8d9505d280dfbfcf697

Martin Davis-3
Is the JTS commit URL even useful then?

Paul says he puts it into the GEOS commit msg, which seems potentially useful. Although there may be multiple commits to get a port completed (ahem - mea culpa).  But there's probably a big initial commit which will be obvious.

I'm tempted to say let's do it all - but might be tedious:

Last port: algorithm/InteriorPointArea.java (JTS-1.17 - 2019/02/19 - a140ca30cc5 )

On Thu, Feb 21, 2019 at 10:44 AM Sandro Santilli <[hidden email]> wrote:
On Thu, Feb 21, 2019 at 10:32:48AM -0800, Martin Davis wrote:
> So we understand, what is the use case here?  Are you grepping to find all
> GEOS files which were changed from a given JTS commit?
>
> If so, do you want any extra tag for the hashlet?   Give us an example of
> the standard form...

Use case is: to get a feel of which files were ported when, I grep
for 'Last Port' in all files.

Works better with SVN revisions and dates and human readable versions
than with hashes indeed, so feel free to leave the hash where it is :)

--strk;
_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel