Period to review pull requests

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Period to review pull requests

Jose Garcia

Related to pull requests, would be nice to give at least 1 day before merging so other developers (even if not assigned as reviewers) can check the code if they want and have time, to add any feedback. Unless for sure it's a PR that solves something really critical.

In 1 day is very unlikely that code changes so much that the pull request has to be re-done and as said gives other developers time to review for any code improvement or questions.

Thanks for your understanding and regards,
Jose García

Vriendelijke groeten / Kind regards,

Jose García

Veenderweg 13
6721 WD Bennekom
The Netherlands
T: <a href="tel:+31318416664" style="font-family:Helvetica,Arial,sans-serif" target="_blank">+31 (0)318 416664


Please consider the environment before printing this email.

Check out the vibrant tech community on one of the world's most
engaging tech sites,!
GeoNetwork-devel mailing list
[hidden email]
GeoNetwork OpenSource is maintained at