Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

Jackie Ng
Hi All,

I've attached a patch for ticket 837

http://trac.osgeo.org/fdo/ticket/837

This patch adds support to the SHP provider for the FdoIGetSchemaNames, FdoIGetClassNames and FdoIDescribeSchema with class name hint and includes new unit tests to exercise these new enhancements.

If acceptable, I'd like this patch to also be included in the 3.9 branch.

Please review. Thanks.

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

Greg Boone
Hi Jackie, unless there is a very strong user impact, this change should only go into the trunk, and not the 3.9 branch. I would be concerned about the lack of testing at this stage in the release process, especially for any of our Autodesk clients.

Why are you advocating dropping it into the branch?

Greg

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Friday, May 16, 2014 3:43 PM
To: [hidden email]
Subject: [fdo-internals] Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

Hi All,

I've attached a patch for ticket 837

http://trac.osgeo.org/fdo/ticket/837

This patch adds support to the SHP provider for the FdoIGetSchemaNames, FdoIGetClassNames and FdoIDescribeSchema with class name hint and includes new unit tests to exercise these new enhancements.

If acceptable, I'd like this patch to also be included in the 3.9 branch.

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-837-Implement-RFC23-APIs-for-SHP-provider-tp5140835.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

Jackie Ng
Hi Greg,

My main reason for inclusion into 3.9 is so when MapGuide Open Source 2.6 (currently in beta) is finally released, it will have an RFC23-enabled SHP provider included. An RFC23-enabled SHP provider will greatly benefit SHP Feature Sources that connect to directories with lots of SHP files in them, where listing class names and fetching of individual class definitions do not have to wear the performance cost of a full schema walk, which is expensive for a SHP file heavy directory.

Still, it's something I'd *like to have* in 3.9 as opposed to want to have. If it's still too late for 3.9, then disregard that particular part of my statement.

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

Greg Boone
In reply to this post by Jackie Ng
I can't see any issues worth mentioning.  Go ahead and submit in Trunk.

Greg

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Friday, May 16, 2014 3:43 PM
To: [hidden email]
Subject: [fdo-internals] Patch for ticket 837 (Implement RFC23 APIs for SHP provider)

Hi All,

I've attached a patch for ticket 837

http://trac.osgeo.org/fdo/ticket/837

This patch adds support to the SHP provider for the FdoIGetSchemaNames, FdoIGetClassNames and FdoIDescribeSchema with class name hint and includes new unit tests to exercise these new enhancements.

If acceptable, I'd like this patch to also be included in the 3.9 branch.

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-837-Implement-RFC23-APIs-for-SHP-provider-tp5140835.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals