Patch for ticket 827 (xalan build fixes for ubuntu)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for ticket 827 (xalan build fixes for ubuntu)

Jackie Ng
Hi All,

I've attached a patch which allows the internal copy of xalan in the FDO thirdparty tree to build successfully on Ubuntu 11.10 (w/ GCC 4.6)

http://trac.osgeo.org/fdo/ticket/827

Please review. Thanks

- Jackie
Reply | Threaded
Open this post in threaded view
|

RE: Patch for ticket 827 (xalan build fixes for ubuntu)

Greg Boone
Re:   Mutable reference members are not allowed in GCC 4.6 ( source). The patch simply removes this keyword

The members must have been declared Mutable for some reason? What was that reason and how will your change affect the overall behavior of the Xalan package?

Have you checked to determine if this issue has been addressed back in the Xalan source repository?

Greg

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Wednesday, April 11, 2012 5:43 AM
To: [hidden email]
Subject: [fdo-internals] Patch for ticket 827 (xalan build fixes for ubuntu)

Hi All,

I've attached a patch which allows the internal copy of xalan in the FDO thirdparty tree to build successfully on Ubuntu 11.10 (w/ GCC 4.6)

http://trac.osgeo.org/fdo/ticket/827

Please review. Thanks

- Jackie

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-827-xalan-build-fixes-for-ubuntu-tp4831505p4831505.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
Reply | Threaded
Open this post in threaded view
|

RE: Patch for ticket 827 (xalan build fixes for ubuntu)

Jackie Ng
If we follow the gcc bug that changed this behaviour:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33558

It was that the C++ standard does not allow the 'mutable' specifier to be applied to reference members. Builds of current/previous xalan releases must've obviously been built with more lenient compilers which overlooked this part of the standard, so I'd guess the developers didn't know such code was illegal.

As for whether such changes have been made back upstream, it's been in the xalan trunk for a year and a half now (relevant JIRA issues are XALANC-643 and XALANC-703):

One of the patched headers (with mutable keyword removed): http://svn.apache.org/viewvc/xalan/c/trunk/src/xalanc/PlatformSupport/XSLException.hpp?view=markup&sortdir=down

One of the patched Makefile.in files (with re-ordered linker flags at lines 177, 185, 195): http://svn.apache.org/viewvc/xalan/c/trunk/src/xalanc/Makefile.in?view=markup&sortdir=down

- Jackie
Reply | Threaded
Open this post in threaded view
|

RE: Patch for ticket 827 (xalan build fixes for ubuntu)

Greg Boone
OK.

The changes look good for Branches/3.7 and the Trunk.

Greg

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Wednesday, April 11, 2012 12:30 PM
To: [hidden email]
Subject: [fdo-internals] RE: Patch for ticket 827 (xalan build fixes for ubuntu)

If we follow the gcc bug that changed this behaviour:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33558

It was that the C++ standard does not allow the 'mutable' specifier to be applied to reference members. Builds of current/previous xalan releases must've obviously been built with more lenient compilers which overlooked this part of the standard, so I'd guess the developers didn't know such code was illegal.

As for whether such changes have been made back upstream, it's been in the xalan trunk for a year and a half now (relevant JIRA issues are XALANC-643 and XALANC-703):

One of the patched headers (with mutable keyword removed):
http://svn.apache.org/viewvc/xalan/c/trunk/src/xalanc/PlatformSupport/XSLException.hpp?view=markup&sortdir=down

One of the patched Makefile.in files (with re-ordered linker flags at lines 177, 185, 195):
http://svn.apache.org/viewvc/xalan/c/trunk/src/xalanc/Makefile.in?view=markup&sortdir=down

- Jackie

--
View this message in context: http://osgeo-org.1560.n6.nabble.com/Patch-for-ticket-827-xalan-build-fixes-for-ubuntu-tp4831505p4832739.html
Sent from the FDO Internals mailing list archive at Nabble.com.
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals
_______________________________________________
fdo-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/fdo-internals