Patch for ticket 532 (MGOS should find fonts on Linux)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for ticket 532 (MGOS should find fonts on Linux)

Jackie Ng
Hi All,

I've made a patch for ticket 532

http://trac.osgeo.org/mapguide/ticket/532

This adds a new general Linux-only serverconfig.ini property (LinuxFontDirectories) that specifies a comma-delimited list of directories where MapGuide should look for additional fonts. Fonts from these directories are loaded into the FontManager as part of server initialization.

This eliminates the need of having to copy the required physical font files into the MapGuide Server's bin directory on Linux to avoid incorrect/hieroglyphic labels being rendered.

Please review. Thanks.

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 532 (MGOS should find fonts on Linux)

weltonw
Two things:

1. To avoid code duplication, have the Linux version of FontManager::init_font_list() now call your new AddLinuxFontDirectory method with the default font directory (".").

2. Would it be better to use ":" as the path separator?  That's the default used in Linux, and could also work ok for Windows.


Otherwise patch looks good to me.

Walt

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Tuesday, September 30, 2014 11:33 AM
To: [hidden email]
Subject: [mapguide-internals] Patch for ticket 532 (MGOS should find fonts on Linux)

Hi All,

I've made a patch for ticket 532

http://trac.osgeo.org/mapguide/ticket/532

This adds a new general Linux-only serverconfig.ini property
(LinuxFontDirectories) that specifies a comma-delimited list of directories where MapGuide should look for additional fonts. Fonts from these directories are loaded into the FontManager as part of server initialization.

This eliminates the need of having to copy the required physical font files into the MapGuide Server's bin directory on Linux to avoid incorrect/hieroglyphic labels being rendered.

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-532-MGOS-should-find-fonts-on-Linux-tp5165013.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 532 (MGOS should find fonts on Linux)

Jackie Ng
2nd patch added.
 - init_font_list() for Linux now calls AddLinuxFontDirectory(".")
 - Use ":" as path separator

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 532 (MGOS should find fonts on Linux)

weltonw
In reply to this post by Jackie Ng
Looks good.  Thanks.

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Wednesday, October 01, 2014 2:58 AM
To: [hidden email]
Subject: Re: [mapguide-internals] Patch for ticket 532 (MGOS should find fonts on Linux)

2nd patch added.
 - init_font_list() for Linux now calls AddLinuxFontDirectory(".")
 - Use ":" as path separator

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-532-MGOS-should-find-fonts-on-Linux-tp5165013p5165145.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals