Patch for ticket 2548 (Selection not cleared server-side)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for ticket 2548 (Selection not cleared server-side)

Jackie Ng
Hi All,

I've attached a patch for ticket 2548

http://trac.osgeo.org/mapguide/ticket/2548

When the fix for ticket 2464 (http://trac.osgeo.org/mapguide/ticket/2464) was made, the case for clearing a selection was not properly handled. This exists as a call to QUERYMAPFEATURES with an empty FEATUREFILTER and no GEOMETRY specified.

The existing RenderForSelection method throws an argument exception on this particular condition (empty feature filter and null geometry). This patch changes the check to return from the method immediately.

The net result of this patch is that it allows for the QUERYMAPFEATURES operation in the mapagent to properly clear selections by omitting the GEOMETRY and FEATUREFILTER parameters.

Please review. Thanks.

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 2548 (Selection not cleared server-side)

weltonw
+1 from me

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Tuesday, March 10, 2015 11:58 AM
To: [hidden email]
Subject: [mapguide-internals] Patch for ticket 2548 (Selection not cleared server-side)

Hi All,

I've attached a patch for ticket 2548

http://trac.osgeo.org/mapguide/ticket/2548

When the fix for ticket 2464 (http://trac.osgeo.org/mapguide/ticket/2464)
was made, the case for clearing a selection was not properly handled. This exists as a call to QUERYMAPFEATURES with an empty FEATUREFILTER and no GEOMETRY specified.

The existing RenderForSelection method throws an argument exception on this particular condition (empty feature filter and null geometry). This patch changes the check to return from the method immediately.

The net result of this patch is that it allows for the QUERYMAPFEATURES operation in the mapagent to properly clear selections by omitting the GEOMETRY and FEATUREFILTER parameters.

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-2548-Selection-not-cleared-server-side-tp5192590.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals