Patch for ticket 1657 (64-bit Linux support)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for ticket 1657 (64-bit Linux support)

Jackie Ng
Hi All,

I've made a patch for ticket 1657

http://trac.osgeo.org/mapguide/ticket/1657

This patch changes the typedefs of INT8/UINT8/INT16/UINT16/INT32/UINT32/INT64/UINT64 on Linux to match the typedefs for these equivalent data types in FDO.

With this patch, the MapGuide test suite (sans Coordinate System tests) will fully pass and fixes the 2 blockers for 64-bit Linux that I identified in this thread:

http://osgeo-org.1560.x6.nabble.com/Any-version-of-MGOS-64bit-on-Linux-available-td5158750.html

For reference, the items mentioned are:

3. MapGuide feeds incorrect AGF binary data to FDO in 64-bit linux. Causes MapGuide-issued spatial queries to fail as FDO is not creating the correct FDO query geometries from the byte array fed from the MgAgfReaderWriter
4. MgMapBase destructor segfaults when attempting to save a MgMap. This breaks any attempts to save map state and prevents the AJAX and Fusion viewers from properly initializing (as both do a MgMap.Save() as part of its initialization)

Please review. Thanks.

- Jackie
Reply | Threaded
Open this post in threaded view
|

Re: Patch for ticket 1657 (64-bit Linux support)

weltonw
Looks good to me.

You can make the years in the copyright for the new files you added just be 2014.

Walt

-----Original Message-----
From: [hidden email] [mailto:[hidden email]] On Behalf Of Jackie Ng
Sent: Thursday, October 09, 2014 1:16 AM
To: [hidden email]
Subject: [mapguide-internals] Patch for ticket 1657 (64-bit Linux support)

Hi All,

I've made a patch for ticket 1657

http://trac.osgeo.org/mapguide/ticket/1657

This patch changes the typedefs of
INT8/UINT8/INT16/UINT16/INT32/UINT32/INT64/UINT64 on Linux to match the typedefs for these equivalent data types in FDO.

With this patch, the MapGuide test suite (sans Coordinate System tests) will fully pass and fixes the 2 blockers for 64-bit Linux that I identified in this thread:

http://osgeo-org.1560.x6.nabble.com/Any-version-of-MGOS-64bit-on-Linux-available-td5158750.html

For reference, the items mentioned are:

3. MapGuide feeds incorrect AGF binary data to FDO in 64-bit linux. Causes MapGuide-issued spatial queries to fail as FDO is not creating the correct FDO query geometries from the byte array fed from the MgAgfReaderWriter 4. MgMapBase destructor segfaults when attempting to save a MgMap. This breaks any attempts to save map state and prevents the AJAX and Fusion viewers from properly initializing (as both do a MgMap.Save() as part of its
initialization)

Please review. Thanks.

- Jackie



--
View this message in context: http://osgeo-org.1560.x6.nabble.com/Patch-for-ticket-1657-64-bit-Linux-support-tp5166587.html
Sent from the MapGuide Internals mailing list archive at Nabble.com.
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals
_______________________________________________
mapguide-internals mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/mapguide-internals