OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

HATRI Aurelien

Hello,

 

First of all thanks for the good job you guys are doing on the library.

 

So my issue is on the modify feature example.

I can’t remove a vertex on a Polygon or on a Line with the IE8 and IE7 in 2.13. It worked in 2.12.

 

I didn’t dig very deeply but it seems that now because ModifyFeature doesn’t use anymore the DragFeature control after a keydown event OL can’t find anymore the vertex feature’s id with getFeatureIdFromEvent.

 

It feels IE 8/7 issue here.

 

Before I try to push further it will be great if you can find the time to look at it.

 

Thanks in advance.

Regards.

 


Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité du groupe Atos ne pourra être engagée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être engagée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavors to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.


_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
Reply | Threaded
Open this post in threaded view
|

Re: OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

Andreas Hocevar-2
It looks like the srcElement of the event we're handling in handleKeypress is the focused element. So I guess it will be necessary to pass the drag handler's last move event instead of the keypress event to the layer's getFeatureIdFromEvent method.

A pull request with a fix would be much appreciated.

Thanks!
Andreas.


On Tue, Aug 13, 2013 at 4:15 PM, HATRI Aurelien <[hidden email]> wrote:

Hello,

 

First of all thanks for the good job you guys are doing on the library.

 

So my issue is on the modify feature example.

I can’t remove a vertex on a Polygon or on a Line with the IE8 and IE7 in 2.13. It worked in 2.12.

 

I didn’t dig very deeply but it seems that now because ModifyFeature doesn’t use anymore the DragFeature control after a keydown event OL can’t find anymore the vertex feature’s id with getFeatureIdFromEvent.

 

It feels IE 8/7 issue here.

 

Before I try to push further it will be great if you can find the time to look at it.

 

Thanks in advance.

Regards.

 


Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité du groupe Atos ne pourra être engagée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être engagée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavors to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.


_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev




--
Andreas Hocevar
OpenGeo - http://opengeo.org/
Expert service straight from the developers.

_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
Reply | Threaded
Open this post in threaded view
|

Re: OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

HATRI Aurelien

Andreas,

 

Thanks for your reactivity.

It’s important for us to make it work on IE8/7 so we will definitely look for a fix ASAP.

 

As far as I’m concerned a pull request we follow. J

 

De : [hidden email] [mailto:[hidden email]] De la part de Andreas Hocevar
Envoyé : mercredi 14 août 2013 00:17
À : HATRI Aurelien
Cc : [hidden email]; SANTOS Daniel
Objet : Re: [OpenLayers-Dev] OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

 

It looks like the srcElement of the event we're handling in handleKeypress is the focused element. So I guess it will be necessary to pass the drag handler's last move event instead of the keypress event to the layer's getFeatureIdFromEvent method.

 

A pull request with a fix would be much appreciated.

 

Thanks!

Andreas.

 

On Tue, Aug 13, 2013 at 4:15 PM, HATRI Aurelien <[hidden email]> wrote:

Hello,

 

First of all thanks for the good job you guys are doing on the library.

 

So my issue is on the modify feature example.

I can’t remove a vertex on a Polygon or on a Line with the IE8 and IE7 in 2.13. It worked in 2.12.

 

I didn’t dig very deeply but it seems that now because ModifyFeature doesn’t use anymore the DragFeature control after a keydown event OL can’t find anymore the vertex feature’s id with getFeatureIdFromEvent.

 

It feels IE 8/7 issue here.

 

Before I try to push further it will be great if you can find the time to look at it.

 

Thanks in advance.

Regards.

 


Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité du groupe Atos ne pourra être engagée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être engagée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavors to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.


_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev



 

--
Andreas Hocevar
OpenGeo - http://opengeo.org/
Expert service straight from the developers.


_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
Reply | Threaded
Open this post in threaded view
|

Re: OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

Xavier Mamano (jorix)
In reply to this post by HATRI Aurelien
Hi,

Try https://github.com/jorix/openlayers/commit/8a30a6b802e03ab61e7ccdfa9fd6b1afcb95deab

HATRI Aurelien wrote
Hello,

First of all thanks for the good job you guys are doing on the library.

So my issue is on the modify feature example.
I can't remove a vertex on a Polygon or on a Line with the IE8 and IE7 in 2.13. It worked in 2.12.

I didn't dig very deeply but it seems that now because ModifyFeature doesn't use anymore the DragFeature control after a keydown event OL can't find anymore the vertex feature's id with getFeatureIdFromEvent.

It feels IE 8/7 issue here.

Before I try to push further it will be great if you can find the time to look at it.

Thanks in advance.
Regards.

________________________________

Ce message et les pi?ces jointes sont confidentiels et r?serv?s ? l'usage exclusif de ses destinataires. Il peut ?galement ?tre prot?g? par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir imm?diatement l'exp?diteur et de le d?truire. L'int?grit? du message ne pouvant ?tre assur?e sur Internet, la responsabilit? du groupe Atos ne pourra ?tre engag?e quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'exp?diteur ne donne aucune garantie ? cet ?gard et sa responsabilit? ne saurait ?tre engag?e pour tout dommage r?sultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavors to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.

_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
Reply | Threaded
Open this post in threaded view
|

Re: OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

HATRI Aurelien
In reply to this post by HATRI Aurelien
Hi Xavier,

It seems ok to me.
As suggested by Andreas you used the event caught by the drag handler, well done !
I will use your patch from now.

Thanks !

-----Message d'origine-----
De : [hidden email] [mailto:[hidden email]] De la part de Xavier Mamano (jorix)
Envoyé : dimanche 18 août 2013 21:13
À : [hidden email]
Objet : Re: [OpenLayers-Dev] OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex


Hi,

Try
https://github.com/jorix/openlayers/commit/8a30a6b802e03ab61e7ccdfa9fd6b1afcb95deab


HATRI Aurelien wrote

> Hello,
>
> First of all thanks for the good job you guys are doing on the library.
>
> So my issue is on the modify feature example.
> I can't remove a vertex on a Polygon or on a Line with the IE8 and IE7
> in 2.13. It worked in 2.12.
>
> I didn't dig very deeply but it seems that now because ModifyFeature
> doesn't use anymore the DragFeature control after a keydown event OL
> can't find anymore the vertex feature's id with getFeatureIdFromEvent.
>
> It feels IE 8/7 issue here.
>
> Before I try to push further it will be great if you can find the time
> to look at it.
>
> Thanks in advance.
> Regards.
>
> ________________________________
>
> Ce message et les pi?ces jointes sont confidentiels et r?serv?s ?
> l'usage exclusif de ses destinataires. Il peut ?galement ?tre prot?g?
> par le secret professionnel. Si vous recevez ce message par erreur,
> merci d'en avertir imm?diatement l'exp?diteur et de le d?truire.
> L'int?grit? du message ne pouvant ?tre assur?e sur Internet, la
> responsabilit? du groupe Atos ne pourra ?tre engag?e quant au contenu
> de ce message. Bien que les meilleurs efforts soient faits pour
> maintenir cette transmission exempte de tout virus, l'exp?diteur ne
> donne aucune garantie ? cet ?gard et sa responsabilit? ne saurait ?tre
> engag?e pour tout dommage r?sultant d'un virus transmis.
>
> This e-mail and the documents attached are confidential and intended
> solely for the addressee; it may also be privileged. If you receive
> this e-mail in error, please notify the sender immediately and destroy
> it. As its integrity cannot be secured on the Internet, the Atos group
> liability cannot be triggered for the message content. Although the
> sender endeavors to maintain a computer virus-free network, the sender
> does not warrant that this transmission is virus-free and will not be
> liable for any damages resulting from any virus transmitted.
>
> _______________________________________________
> Dev mailing list

> Dev@.osgeo

> http://lists.osgeo.org/mailman/listinfo/openlayers-dev





--
View this message in context: http://osgeo-org.1560.x6.nabble.com/OL-2-13-Modify-Feature-Example-IE8-IE7-Can-t-remove-vertex-tp5072314p5073039.html
Sent from the OpenLayers Dev mailing list archive at Nabble.com.
_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
________________________________


Ce message et les pièces jointes sont confidentiels et réservés à l'usage exclusif de ses destinataires. Il peut également être protégé par le secret professionnel. Si vous recevez ce message par erreur, merci d'en avertir immédiatement l'expéditeur et de le détruire. L'intégrité du message ne pouvant être assurée sur Internet, la responsabilité du groupe Atos ne pourra être engagée quant au contenu de ce message. Bien que les meilleurs efforts soient faits pour maintenir cette transmission exempte de tout virus, l'expéditeur ne donne aucune garantie à cet égard et sa responsabilité ne saurait être engagée pour tout dommage résultant d'un virus transmis.

This e-mail and the documents attached are confidential and intended solely for the addressee; it may also be privileged. If you receive this e-mail in error, please notify the sender immediately and destroy it. As its integrity cannot be secured on the Internet, the Atos group liability cannot be triggered for the message content. Although the sender endeavors to maintain a computer virus-free network, the sender does not warrant that this transmission is virus-free and will not be liable for any damages resulting from any virus transmitted.
_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
Reply | Threaded
Open this post in threaded view
|

Re: OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

Andreas Hocevar-2
In reply to this post by Xavier Mamano (jorix)
Great work @jorix - would you mind creating a pull request? I'll review immediately.

Thanks!
Andreas.


On Sun, Aug 18, 2013 at 9:13 PM, Xavier Mamano (jorix) <[hidden email]> wrote:
Hi,

Try
https://github.com/jorix/openlayers/commit/8a30a6b802e03ab61e7ccdfa9fd6b1afcb95deab


HATRI Aurelien wrote
> Hello,
>
> First of all thanks for the good job you guys are doing on the library.
>
> So my issue is on the modify feature example.
> I can't remove a vertex on a Polygon or on a Line with the IE8 and IE7 in
> 2.13. It worked in 2.12.
>
> I didn't dig very deeply but it seems that now because ModifyFeature
> doesn't use anymore the DragFeature control after a keydown event OL can't
> find anymore the vertex feature's id with getFeatureIdFromEvent.
>
> It feels IE 8/7 issue here.
>
> Before I try to push further it will be great if you can find the time to
> look at it.
>
> Thanks in advance.
> Regards.
>
> ________________________________
>
> Ce message et les pi?ces jointes sont confidentiels et r?serv?s ? l'usage
> exclusif de ses destinataires. Il peut ?galement ?tre prot?g? par le
> secret professionnel. Si vous recevez ce message par erreur, merci d'en
> avertir imm?diatement l'exp?diteur et de le d?truire. L'int?grit? du
> message ne pouvant ?tre assur?e sur Internet, la responsabilit? du groupe
> Atos ne pourra ?tre engag?e quant au contenu de ce message. Bien que les
> meilleurs efforts soient faits pour maintenir cette transmission exempte
> de tout virus, l'exp?diteur ne donne aucune garantie ? cet ?gard et sa
> responsabilit? ne saurait ?tre engag?e pour tout dommage r?sultant d'un
> virus transmis.
>
> This e-mail and the documents attached are confidential and intended
> solely for the addressee; it may also be privileged. If you receive this
> e-mail in error, please notify the sender immediately and destroy it. As
> its integrity cannot be secured on the Internet, the Atos group liability
> cannot be triggered for the message content. Although the sender endeavors
> to maintain a computer virus-free network, the sender does not warrant
> that this transmission is virus-free and will not be liable for any
> damages resulting from any virus transmitted.
>
> _______________________________________________
> Dev mailing list

> Dev@.osgeo

> http://lists.osgeo.org/mailman/listinfo/openlayers-dev





--
View this message in context: http://osgeo-org.1560.x6.nabble.com/OL-2-13-Modify-Feature-Example-IE8-IE7-Can-t-remove-vertex-tp5072314p5073039.html
Sent from the OpenLayers Dev mailing list archive at Nabble.com.
_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev



--
Andreas Hocevar
OpenGeo - http://opengeo.org/
Expert service straight from the developers.

_______________________________________________
Dev mailing list
[hidden email]
http://lists.osgeo.org/mailman/listinfo/openlayers-dev
Reply | Threaded
Open this post in threaded view
|

Re: OL 2.13 Modify Feature Example IE8/IE7 : Can't remove vertex

Xavier Mamano (jorix)
Hi Andreas,

Ok, done by: https://github.com/openlayers/openlayers/pull/1091

Regards,

Xavier

Andreas Hocevar-2 wrote
Great work @jorix - would you mind creating a pull request? I'll review
immediately.

Thanks!
Andreas.


On Sun, Aug 18, 2013 at 9:13 PM, Xavier Mamano (jorix) <
[hidden email]> wrote: