Improve label WRAP and WRAP regression

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Improve label WRAP and WRAP regression

Oliver Tonnhofer-5
Hi all,

we want to improve label wrapping in MapServer so that road labels can be wrapped at space and dashes.

I created an issue with a request for comments:
https://github.com/mapserver/mapserver/issues/5613

I also found a regression that is related to this:
https://github.com/mapserver/mapserver/issues/5612


Regards,
Oliver

--
Oliver Tonnhofer  | Omniscale GmbH & Co KG  | https://omniscale.com
OpenStreetMap WMS and tile services         | https://maps.omniscale.com







_______________________________________________
mapserver-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/mapserver-dev
Reply | Threaded
Open this post in threaded view
|

Re: Improve label WRAP and WRAP regression

Oliver Tonnhofer-5
Hi,

just a heads-up. I've created a PR to fix the regression and to allow the user to add the Unicode ZERO WIDTH SPACE character in labels to signify possible wrap positions. These positions are independent of the WRAP character. This way you can wrap "Main-Road" and "Main Road" by adding a ZERO WIDTH SPACE after the space/dash. The ZERO WIDTH SPACE will not show up in the rendered output (whether wrapped or not).

You can insert this character with a PostGIS `replace` call. I'll add an example to the documentation.  
 
The PR is at: https://github.com/mapserver/mapserver/pull/5634


I've included two questions:
• I've added a test. How do I generate the expected image? Most "result images perceptually match, though files differ" on my system.
• The patch is against master but I can rebase it. Where? branch-7-2? branch-7-3?


Regards,
Oliver

--
Oliver Tonnhofer  | Omniscale GmbH & Co KG  | https://omniscale.com
OpenStreetMap WMS and tile services         | https://maps.omniscale.com







> On 15. Jun 2018, at 13:05, Oliver Tonnhofer <[hidden email]> wrote:
>
> Hi all,
>
> we want to improve label wrapping in MapServer so that road labels can be wrapped at space and dashes.
>
> I created an issue with a request for comments:
> https://github.com/mapserver/mapserver/issues/5613
>
> I also found a regression that is related to this:
> https://github.com/mapserver/mapserver/issues/5612
>
>
> Regards,
> Oliver
>
> --
> Oliver Tonnhofer  | Omniscale GmbH & Co KG  | https://omniscale.com
> OpenStreetMap WMS and tile services         | https://maps.omniscale.com
>
>
>
>
>
>
>

_______________________________________________
mapserver-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/mapserver-dev
Reply | Threaded
Open this post in threaded view
|

Re: Improve label WRAP and WRAP regression

Lime, Steve D (MNIT)
Other folks are encouraged to check out Oliver's work in github. Looks good from where I sit.

For the questions:

  * test images should be generated via vagrant
  * since this is fixing a bug I think the PR should be done against 7.2 - maybe even 7.0 assuming that’s where the regression was introduced.

Thoughts?

--Steve

-----Original Message-----
From: mapserver-dev [mailto:[hidden email]] On Behalf Of Oliver Tonnhofer
Sent: Wednesday, August 01, 2018 2:05 AM
To: [hidden email]
Subject: Re: [mapserver-dev] Improve label WRAP and WRAP regression

Hi,

just a heads-up. I've created a PR to fix the regression and to allow the user to add the Unicode ZERO WIDTH SPACE character in labels to signify possible wrap positions. These positions are independent of the WRAP character. This way you can wrap "Main-Road" and "Main Road" by adding a ZERO WIDTH SPACE after the space/dash. The ZERO WIDTH SPACE will not show up in the rendered output (whether wrapped or not).

You can insert this character with a PostGIS `replace` call. I'll add an example to the documentation.  
 
The PR is at: https://github.com/mapserver/mapserver/pull/5634


I've included two questions:
• I've added a test. How do I generate the expected image? Most "result images perceptually match, though files differ" on my system.
• The patch is against master but I can rebase it. Where? branch-7-2? branch-7-3?


Regards,
Oliver

--
Oliver Tonnhofer  | Omniscale GmbH & Co KG  | https://omniscale.com
OpenStreetMap WMS and tile services         | https://maps.omniscale.com







> On 15. Jun 2018, at 13:05, Oliver Tonnhofer <[hidden email]> wrote:
>
> Hi all,
>
> we want to improve label wrapping in MapServer so that road labels can be wrapped at space and dashes.
>
> I created an issue with a request for comments:
> https://github.com/mapserver/mapserver/issues/5613
>
> I also found a regression that is related to this:
> https://github.com/mapserver/mapserver/issues/5612
>
>
> Regards,
> Oliver
>
> --
> Oliver Tonnhofer  | Omniscale GmbH & Co KG  | https://omniscale.com
> OpenStreetMap WMS and tile services         | https://maps.omniscale.com
>
>
>
>
>
>
>

_______________________________________________
mapserver-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/mapserver-dev
_______________________________________________
mapserver-dev mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/mapserver-dev