Geonames issue

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Geonames issue

Jo Cook
Hi Developers,

I've been trying to track down an issue with the geonames search used in the drop down region picker when editing a record in Geonetwork 3.4.x (issue https://github.com/geonetwork/core-geonetwork/issues/2803). This is working just fine in 3.2.x but fails with a syntax error in 3.4.x. The geonames search in the map is working just fine.

My web developer colleague thinks it could be an issue with jquery, and highlighted a difference between static/lib.js and jquery in https://github.com/geonetwork/core-geonetwork/blob/3.4.x/web-ui/src/main/resources/catalog/lib/jquery-2.2.4.js. I am uncertain how static/lib.js is generated, but I see that the version of jquery we use was recently updated (https://github.com/geonetwork/core-geonetwork/pull/2520). However, the version in Master is still the old version. 

Are we taking the right approach with this, or is it likely to be something quite different? Can anyone else replicate the issue?

Many thanks

Jo

--
Jo Cook
t:+44 7930 524 155/twitter:@archaeogeek
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009


--
Astun Technology Ltd, The Coach House, 17 West Street, Epsom, Surrey, KT18 7RL, UK 
t:+44 1372 744 009 w: astuntechnology.com twitter:@astuntech

Company registration no. 5410695. Registered in England and Wales. Registered office: 120 Manor Green Road, Epsom, Surrey, KT19 8LN VAT no. 864201149.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
Reply | Threaded
Open this post in threaded view
|

Re: Geonames issue

delawen
I have a PR merging 3.4 into master pending. Should contain all latest until Friday.

If it is not there, we will have to cherry pick.

I think you are asked to review? 

El mar., 19 jun. 2018 18:04, Jo Cook <[hidden email]> escribió:
Hi Developers,

I've been trying to track down an issue with the geonames search used in the drop down region picker when editing a record in Geonetwork 3.4.x (issue https://github.com/geonetwork/core-geonetwork/issues/2803). This is working just fine in 3.2.x but fails with a syntax error in 3.4.x. The geonames search in the map is working just fine.

My web developer colleague thinks it could be an issue with jquery, and highlighted a difference between static/lib.js and jquery in https://github.com/geonetwork/core-geonetwork/blob/3.4.x/web-ui/src/main/resources/catalog/lib/jquery-2.2.4.js. I am uncertain how static/lib.js is generated, but I see that the version of jquery we use was recently updated (https://github.com/geonetwork/core-geonetwork/pull/2520). However, the version in Master is still the old version. 

Are we taking the right approach with this, or is it likely to be something quite different? Can anyone else replicate the issue?

Many thanks

Jo

--
Jo Cook
t:+44 7930 524 155/twitter:@archaeogeek
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009


--
Astun Technology Ltd, The Coach House, 17 West Street, Epsom, Surrey, KT18 7RL, UK 
t:+44 1372 744 009 w: astuntechnology.com twitter:@astuntech

Company registration no. 5410695. Registered in England and Wales. Registered office: 120 Manor Green Road, Epsom, Surrey, KT19 8LN VAT no. 864201149.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork
Reply | Threaded
Open this post in threaded view
|

Re: Geonames issue

Jo Cook
Hi Maria,

Yes I have been asked to review it, but to the best of my knowledge no one has worked on the issue I linked to, so it's not included in that list. It is marked as a bug but not attached to any particular milestone.

Thanks

Jo

On Tue, Jun 19, 2018 at 5:21 PM, María Arias de Reyna <[hidden email]> wrote:
I have a PR merging 3.4 into master pending. Should contain all latest until Friday.

If it is not there, we will have to cherry pick.

I think you are asked to review? 

El mar., 19 jun. 2018 18:04, Jo Cook <[hidden email]> escribió:
Hi Developers,

I've been trying to track down an issue with the geonames search used in the drop down region picker when editing a record in Geonetwork 3.4.x (issue https://github.com/geonetwork/core-geonetwork/issues/2803). This is working just fine in 3.2.x but fails with a syntax error in 3.4.x. The geonames search in the map is working just fine.

My web developer colleague thinks it could be an issue with jquery, and highlighted a difference between static/lib.js and jquery in https://github.com/geonetwork/core-geonetwork/blob/3.4.x/web-ui/src/main/resources/catalog/lib/jquery-2.2.4.js. I am uncertain how static/lib.js is generated, but I see that the version of jquery we use was recently updated (https://github.com/geonetwork/core-geonetwork/pull/2520). However, the version in Master is still the old version. 

Are we taking the right approach with this, or is it likely to be something quite different? Can anyone else replicate the issue?

Many thanks

Jo

--
Jo Cook
t:+44 7930 524 155/twitter:@archaeogeek
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009


--
Astun Technology Ltd, The Coach House, 17 West Street, Epsom, Surrey, KT18 7RL, UK 
t:+44 1372 744 009 w: astuntechnology.com twitter:@astuntech

Company registration no. 5410695. Registered in England and Wales. Registered office: 120 Manor Green Road, Epsom, Surrey, KT19 8LN VAT no. 864201149.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork



--
Jo Cook
t:+44 7930 524 155/twitter:@archaeogeek
Please note that currently I do not work on Friday afternoons. For urgent responses at that time, please visit support.astuntechnology.com or phone our office on 01372 744009


--
Astun Technology Ltd, The Coach House, 17 West Street, Epsom, Surrey, KT18 7RL, UK 
t:+44 1372 744 009 w: astuntechnology.com twitter:@astuntech

Company registration no. 5410695. Registered in England and Wales. Registered office: 120 Manor Green Road, Epsom, Surrey, KT19 8LN VAT no. 864201149.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoNetwork-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/geonetwork-devel
GeoNetwork OpenSource is maintained at http://sourceforge.net/projects/geonetwork