[GEOS] #941: Incorrect values returned on error in CAPI

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[GEOS] #941: Incorrect values returned on error in CAPI

geos-2
#941: Incorrect values returned on error in CAPI
------------------------+--------------------------
 Reporter:  dbaston     |      Owner:  geos-devel@…
     Type:  defect      |     Status:  new
 Priority:  major       |  Milestone:
Component:  Default     |    Version:  3.6.2
 Severity:  Unassigned  |   Keywords:
------------------------+--------------------------
 In some cases, the CAPI function `GEOSLength_r` returns `2` on error, when
 it is documented to return `0`. The `2` is likely to be interpreted as
 "success" by a caller.

 In some cases, the CAPI function `GEOSIsValidDetail_r` returns `0` on
 error, when it is documented to return `2`. The `0` would be falsely
 interpreted as "geometry invalid."

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/941>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #941: Incorrect values returned on error in CAPI

geos-2
#941: Incorrect values returned on error in CAPI
------------------------+---------------------------
 Reporter:  dbaston     |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  major       |   Milestone:
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by dbaston):

 PR at https://github.com/libgeos/geos/pull/131

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/941#comment:1>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #941: Incorrect values returned on error in CAPI

geos-2
In reply to this post by geos-2
#941: Incorrect values returned on error in CAPI
------------------------+---------------------------
 Reporter:  dbaston     |       Owner:  geos-devel@…
     Type:  defect      |      Status:  closed
 Priority:  major       |   Milestone:
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:  fixed
 Keywords:              |
------------------------+---------------------------
Changes (by Daniel Baston <dbaston@…>):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"bfe6b8bb635163a96bfba7a17383eb386486ec60/git" bfe6b8b/git]:
 {{{
 #!CommitTicketReference repository="git"
 revision="bfe6b8bb635163a96bfba7a17383eb386486ec60"
 Fix incorrect error return values in CAPI

 Fixes #941
 }}}

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/941#comment:2>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #941: Incorrect values returned on error in CAPI

geos-2
In reply to this post by geos-2
#941: Incorrect values returned on error in CAPI
------------------------+---------------------------
 Reporter:  dbaston     |       Owner:  geos-devel@…
     Type:  defect      |      Status:  closed
 Priority:  major       |   Milestone:
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:  fixed
 Keywords:              |
------------------------+---------------------------

Comment (by Daniel Baston <dbaston@…>):

 In [changeset:"038813ea1d28a57eae4c2f9adb03db2c24e000d0/git"
 038813ea/git]:
 {{{
 #!CommitTicketReference repository="git"
 revision="038813ea1d28a57eae4c2f9adb03db2c24e000d0"
 Fix incorrect error return values in CAPI

 Fixes #941
 }}}

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/941#comment:3>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #941: Incorrect values returned on error in CAPI

geos-2
In reply to this post by geos-2
#941: Incorrect values returned on error in CAPI
------------------------+---------------------------
 Reporter:  dbaston     |       Owner:  geos-devel@…
     Type:  defect      |      Status:  closed
 Priority:  major       |   Milestone:
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:  fixed
 Keywords:              |
------------------------+---------------------------

Comment (by Daniel Baston <dbaston@…>):

 In [changeset:"d1a649fcbeeffa3a21e7d2bf66e7f545a73a2388/git" d1a649f/git]:
 {{{
 #!CommitTicketReference repository="git"
 revision="d1a649fcbeeffa3a21e7d2bf66e7f545a73a2388"
 Fix incorrect error return values in CAPI

 Fixes #941
 }}}

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/941#comment:4>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel