[GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

geos-2
#867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2
------------------------+--------------------------
 Reporter:  robe        |      Owner:  geos-devel@…
     Type:  defect      |     Status:  new
 Priority:  blocker     |  Milestone:  3.6.3
Component:  Default     |    Version:  3.6.2
 Severity:  Unassigned  |   Keywords:
------------------------+--------------------------
 Reported on PostGIS mailing lists

 https://lists.osgeo.org/pipermail/postgis-users/2018-April/042710.html

 Example is exercised in PostGIS, but I concluded the issue is a change
 that happened between GEOS 3.6.1 and 3.6.2

 I'll link to the related PostGIS ticket once it's put in.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/867>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

geos-2
#867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2
------------------------+---------------------------
 Reporter:  robe        |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  blocker     |   Milestone:  3.6.3
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by robe):

 Related postgis ticket

 https://trac.osgeo.org/postgis/ticket/4075

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/867#comment:1>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

geos-2
In reply to this post by geos-2
#867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2
------------------------+---------------------------
 Reporter:  robe        |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  blocker     |   Milestone:  3.6.3
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by bjornharrtell):

 Looking into this it seems a likely candidate for this regression is the
 work to fix a robustness issue as described by
 https://trac.osgeo.org/geos/ticket/837.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/867#comment:2>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

geos-2
In reply to this post by geos-2
#867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2
------------------------+---------------------------
 Reporter:  robe        |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  blocker     |   Milestone:  3.6.3
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by robe):

 bjornharrtell,

 Thanks for looking into this.  I'm planning to test this out today so will
 know for sure if reverting this fixes the issue.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/867#comment:3>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

geos-2
In reply to this post by geos-2
#867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2
------------------------+---------------------------
 Reporter:  robe        |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  blocker     |   Milestone:  3.6.3
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by robe):

 Confirmed this behemoth of a commit is the culprit.

 Testing with: 3.6.2dev 459ae2f  (which commit before the #837 one) takes
 29.7 secs

 Testing with the #837 commit (3.6.2dev-CAPI-1.10.2 3975725)

 Takes 2:35 minutes.

 I'll reopen that one.

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/867#comment:4>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel
Reply | Threaded
Open this post in threaded view
|

Re: [GEOS] #867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2

geos-2
In reply to this post by geos-2
#867: Regression in union algorithm between GEOS 3.6.1 and GEOS 3.6.2
------------------------+---------------------------
 Reporter:  robe        |       Owner:  geos-devel@…
     Type:  defect      |      Status:  new
 Priority:  blocker     |   Milestone:  3.6.3
Component:  Default     |     Version:  3.6.2
 Severity:  Unassigned  |  Resolution:
 Keywords:              |
------------------------+---------------------------

Comment (by robe):

 Okay I nailed it down to this area and got it at least for this example to
 behavior like the old behavior.  Thus probably wiping out your intent.

 https://git.osgeo.org/gitea/geos/geos/pulls/28

--
Ticket URL: <https://trac.osgeo.org/geos/ticket/867#comment:5>
GEOS <http://trac.osgeo.org/geos>
GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).

_______________________________________________
geos-devel mailing list
[hidden email]
https://lists.osgeo.org/mailman/listinfo/geos-devel